Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attempt one record per subject and laboratory test carrying the collected result in AVAL and the upper limit of normal for that test and the subject's sex in ANRHI.

Input: collected laboratory results carrying the collected result (LBSTRESN), test code (LBTESTCD), and sex (SEX), plus a reference table of upper limits by test code and sex.

Variables:

  • SEX would be the sex the limits are chosen by, copied from the collected record.
  • AVAL would be the collected result, copied from LBSTRESN.
  • ANRHI would be the upper limit of normal for that test and sex, found by matching the collected test code and SEX against the reference table; missing when the table has no limit for that pair or the sex is missing.

Note: the limits are named as the folder input/lbref rather than a table file. A folder holds whatever is added to it, so the limits a run would read depend on what happens to be filed there, and two runs of one study could disagree. The run is rejected before any data is read and no artifact is accepted.

How to fix

Decide which reviewed table the study was approved against. When limits arrive as several files, combine them into one reviewed table first, then name that table instead of the folder that holds it:

input:
  LBREF:
    path: input/lbref/limits.csv

A study reads the table it was approved against, not a folder that grows.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
resource_path_not_regular_file
requirement
REQ-0785
expected/error.yaml
phase: validation
condition: resource_path_not_regular_file
spec_paths:
  - input.LBREF.path
requirement: REQ-0785
context:
  dataset: LBREF
  path: input/lbref

Inputs

Under review
2 source files

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDSEXLBSTRESN
PILOT7ALTF42
PILOT7ALTM58

input/lbref/limits.csv

Edit
2 rows
input/lbref/limits.csv
LBTESTCDSEXANRHI
ALTF33
ALTM41

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBSEXSexcharacterCopy value from LB.SEX.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericTake ANRHI from the LBREF record whose LBTESTCD equals PARAMCD and SEX equals SEX, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml