Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build one record for every subject carrying the collected age (AGE) and sex (SEX). Each subject may appear only once in the result.

Input: collected demographics records carrying age (AGE) and sex (SEX).

Variables:

  • AGE would be the collected age, carried into the result unchanged.
  • SEX would be the sex collected in the demographics records, carried into the result unchanged.

Note: the result is built one row per collected record, so a subject entered twice reaches the result twice. That rejects the run even when the two records agree; here they also disagree on the age, and keeping either record, or merging the two, would report an age the collected data does not support. The expected file shows the completed rows as they reach the one-row-per-subject check, but the repeated subject still rejects the run and no artifact is accepted.

How to fix

Reconcile the two source records and correct the governed demographics input so it contains one supported age for the subject. If multiple source records are legitimate, build the rows from a list holding each subject once and declare an ordered record-selection rule for the demographics record; do not rely on source order to discard one. The completed output must contain exactly one row for each key.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
output
condition
duplicate_key
requirement
REQ-0240
expected/error.yaml
phase: output
condition: duplicate_key
spec_paths:
  - keys
requirement: REQ-0240
context:
  duplicate_count: 1
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-722

Inputs

Under review
1 source file

input/dm.csv

Edit
3 rows
input/dm.csv
STUDYIDUSUBJIDAGESEX
PILOT764F
PILOT758M
PILOT759M

Unexpected Output

Under review
3 rows presented to the failing check - not an accepted artifact

expected/adsl.csv

Edit
3 rows
expected/adsl.csv
STUDYIDUSUBJIDAGESEX
PILOT764F
PILOT758M
PILOT759M
Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLAGEAgenumericCopy value from DM.AGE.Predecessor
ADSLSEXSexcharacterCopy value from DM.SEX.Predecessor
TemplateInclude when
record
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml