Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: derive AGE for one record per subject from the subject's collected answer.

Input: long-form Operational Data Model (ODM) data with one row per collected item, declared with the visit repeat read as a number.

Variables:

  • AGE would be the subject's collected age.

ODM data has one fixed layout, every field text, and the declaration would change it, so the input is rejected before any record is read.

How to fix

Declare the ODM data by its path alone. A value needed as a number is typed where it is used: AGE is declared int, and the collected text converts to it. A visit repeat used as a number is read into its own column:

- name: VISITREP
  type: int
  derivation: ODM.StudyEventRepeatKey

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
odm_schema_field_type
requirement
REQ-1275
expected/error.yaml
phase: validation
condition: odm_schema_field_type
spec_paths:
  - input.ODM.types
requirement: REQ-1275
context:
  dataset: ODM
  declared: types

Inputs

Under review
1 source file

input/odm.csv

Edit
4 rows
input/odm.csv
StudyOIDMetaDataVersionOIDSubjectKeyStudyEventOIDStudyEventRepeatKeyFormOIDFormRepeatKeyItemGroupOIDItemGroupRepeatKeyItemOIDValue
STUDY01MDV.1001SCREENING1FO.DM1IG.DM1IT.DM.SEXF
STUDY01MDV.1001SCREENING1FO.DM1IG.DM1IT.DM.AGE34
STUDY01MDV.1002SCREENING1FO.DM1IG.DM1IT.DM.SEXM
STUDY01MDV.1002SCREENING1FO.DM1IG.DM1IT.DM.AGE28

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from ODM.StudyOID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from ODM.SubjectKey.SDTM2
AGEAgeNumCollectedRead collected ODM item IT.DM.AGE; no identified record yields blank.SDTM3
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml