Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: derive SEX for each subject of a subject list from the subject's collected answer.

Input: a subject list naming each subject, and long-form Operational Data Model (ODM) data with one row per collected item.

Variables:

  • SEX would be the subject's answer to the sex question.

Each record is built from the subject list, so none of them was built from collected items, and an item has no records of its own to be read from. The request is rejected before any data is read.

How to fix

Build the records from the collected items, one per subject, and read the answer there:

input:
  ODM: input/odm.csv
columns:
  - name: USUBJID
    derivation: ODM.SubjectKey
  - name: SEX
    derivation: {odm: ODM.IT.DM.SEX}

A subject list that decides which subjects appear is then a filter or a lookup against those records, not the place they are built from.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
invalid_odm_context
requirement
REQ-1277
expected/error.yaml
phase: validation
condition: invalid_odm_context
spec_paths:
  - columns.SEX.derivation.odm
requirement: REQ-1277
context:
  dataset: ODM
  location: column

Inputs

Under review
2 source files

input/dm_raw.csv

Edit
2 rows
input/dm_raw.csv
STUDYIDUSUBJID
STUDY01
STUDY01

input/odm.csv

Edit
4 rows
input/odm.csv
StudyOIDMetaDataVersionOIDSubjectKeyStudyEventOIDStudyEventRepeatKeyFormOIDFormRepeatKeyItemGroupOIDItemGroupRepeatKeyItemOIDValue
STUDY01MDV.1001SCREENING1FO.DM1IG.DM1IT.DM.SEXF
STUDY01MDV.1001SCREENING1FO.DM1IG.DM1IT.DM.AGE34
STUDY01MDV.1002SCREENING1FO.DM1IG.DM1IT.DM.SEXM
STUDY01MDV.1002SCREENING1FO.DM1IG.DM1IT.DM.AGE28

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from DM_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from DM_RAW.USUBJID.SDTM2
SEXSexCharCollectedRead collected ODM item IT.DM.SEX; no identified record yields blank.SDTM3
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml