Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive body surface area (BSA) for each subject from collected height and weight.

Input: demographic records carrying collected height (HEIGHTCM) and weight (WEIGHTKG).

Variables:

  • BSA would contain body surface area in square meters by the Mosteller formula: height in centimeters (HEIGHTCM) times weight in kilograms (WEIGHTKG), divided by 3600, then square-rooted; missing when either measurement is missing.

Note: when height times weight is negative, as with a negative weight, the area has no real value. Any answer would be invented rather than derived, so the run fails and no artifact is accepted.

How to fix

Confirm and correct the negative weight in the source when it is a data-entry error. If the analysis explicitly treats a non-positive height or weight as unusable, encode that policy and return missing instead of evaluating the square root:

derivation:
  case:
    - when: "HEIGHTCM > 0 AND WEIGHTKG > 0"
      then:
        compute:
          expr: "SQRT(HEIGHTCM * WEIGHTKG / 3600)"

With no otherwise, an invalid measurement produces missing.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
derivation
condition
sqrt_of_negative
requirement
REQ-0431
expected/error.yaml
phase: derivation
condition: sqrt_of_negative
spec_paths:
  - columns.BSA.derivation.compute
requirement: REQ-0431
context:
  expr: "SQRT(HEIGHTCM * WEIGHTKG / 3600)"
  keys:
    - STUDYID: PILOT7
      USUBJID: P7-752

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDHEIGHTCMWEIGHTKG
PILOT716864
PILOT7175-70

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLBSABody Surface Area (m2)numericCompute SQRT(HEIGHTCM * WEIGHTKG / 3600).Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml