Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: attach the standardized medication name (CMDECOD) to each collected concomitant medication by joining the coding team's output to the WHODrug extract.

Input: collected medication verbatims (CMTRT), a coding-team table carrying the selected WHODrug record and ATC code per medication, plus a WHODrug extract carrying the preferred name per record and ATC code.

Variables:

  • CMDECOD would be the preferred name read from the WHODrug extract matched on the coding team's record and ATC code. The coding-team table is also given a second name that selects, computes, and reshapes nothing, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Drop the alias and read the coding-team table under its own name. Its record is matched to each row by study, subject, and sequence number, so also read its sequence number as an integer to compare with CMSEQ:

input:
  CM_RAW: input/cm_raw.csv
  CODING:
    path: input/coding.csv
    types: {CMSEQ: int}
  WHODRUG: input/whodrug.csv
base: CM_RAW

columns:
  - name: CMDECOD
    type: str
    label: Standardized Medication Name
    derivation: WHODRUG_LOOKUP.PREFERRED_NAME

A named intermediate must narrow, derive, or reshape its dataset (REQ-1248).

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
rename_only_intermediate
requirement
REQ-1248
expected/error.yaml
phase: validation
condition: rename_only_intermediate
spec_paths:
  - intermediates[0]
requirement: REQ-1248
context:
  intermediate: CODED
  dataset: CODING

Inputs

Under review
3 source files

input/cm_raw.csv

Edit
3 rows
input/cm_raw.csv
STUDYIDUSUBJIDCMSEQCMTRT
YAMAA-011IBUPROFEN 200MG TABLET
YAMAA-012PARACETAMOL 500MG CAPSULE
YAMAA-011ASPIRIN 100MG TABLET

input/coding.csv

Edit
3 rows
input/coding.csv
STUDYIDUSUBJIDCMSEQDRUG_RECORD_NOATC_CODE
YAMAA-011000001M01AE01
YAMAA-012000002N02BE01
YAMAA-011000003B01AC06

input/whodrug.csv

Edit
3 rows
input/whodrug.csv
DRUG_RECORD_NOATC_CODEPREFERRED_NAME
000001M01AE01Ibuprofen
000002N02BE01Paracetamol
000003B01AC06Acetylsalicylic acid

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from CM_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from CM_RAW.USUBJID.SDTM2
CMSEQSequence NumberNumCollectedCopy value from CM_RAW.CMSEQ.SDTM3
CMTRTReported Name of Drug, Med, or TherapyCharCollectedCopy value from CM_RAW.CMTRT.SDTM4
CMDECODStandardized Medication NameCharDerivedTake PREFERRED_NAME from the WHODRUG record whose DRUG_RECORD_NO equals CODING.DRUG_RECORD_NO and ATC_CODE equals CODING.ATC_CODE, and a row with no match is an error.SDTM5
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml