Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the first treatment received in TRT01A, one record per subject.

Input: demographics records plus exposure records carrying the administration sequence number (EXSEQ), the treatment name (EXTRT), and the administration start date (EXSTDTC).

Variables:

  • TRT01A would contain the treatment name from the earliest exposure record.

Note: the chosen record is named EX, which already names the exposure records, so a read of EX.EXTRT cannot say whether it means the treatment of the chosen record or of every exposure record. The two readings differ whenever a subject has more than one administration. The name itself is rejected before any data is read, so no artifact is accepted.

How to fix

Give the record lookup a name that is distinct from every dataset and from the output domain, then read through that name:

intermediates:
  - id: FIRSTEX
    dataset: EX
    order_by: [EX.EXSTDTC, EX.EXSEQ]
    keep: first

# ...
derivation:
  source: FIRSTEX.EXTRT

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
duplicate_identifier
requirement
REQ-0113
expected/error.yaml
phase: validation
condition: duplicate_identifier
spec_paths:
  - intermediates[0].id
  - input.EX
requirement: REQ-0113
context:
  identifier: EX

Inputs

Under review
2 source files

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJID
YAMAA-01
YAMAA-01

input/ex.csv

Edit
3 rows
input/ex.csv
STUDYIDUSUBJIDEXSEQEXTRTEXSTDTC
YAMAA-011Carboplatin2023-03-01
YAMAA-012Pemetrexed2023-03-22
YAMAA-011Carboplatin2023-04-10

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLTRT01AActual Treatment for Period 01characterTake EXTRT from the first EX record matching on the shared output keys, ordered by EX.EXSTDTC then EX.EXSEQ, and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml