Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: derive each subject's end-of-study date (EOSDT) from the subject's one end-of-study disposition record.

Input: demographics records with disposition records carrying category (DSCAT), decoded term (DSDECOD), and start date (DSSTDTC).

Variables:

  • EOSDT would be the start date of the subject's end-of-study record, the disposition event that is not a screen failure, and blank when the subject has none. The study expects at most one such record per subject; a subject with two has no single end-of-study date, so the run is rejected before any output row is built and no artifact is accepted.

How to fix

Give each subject exactly one eligible end-of-study record in the source data. When the source cannot promise that, drop the uniqueness assertion and choose the record explicitly instead, here the one with the latest start date:

intermediates:
  - id: DS_EOS
    dataset: DS
    filter: "DS.DSCAT = 'DISPOSITION EVENT' AND DS.DSDECOD <> 'SCREEN FAILURE'"
    order_by: [DS.DSSTDTC]
    keep: last
    no_match: null

The no_match line leaves EOSDT blank for a subject with no eligible record, one whose only disposition records are screen failures, instead of failing the lookup.

Keep the uniqueness assertion only for eligible sets that truly carry each key once.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
verification
condition
duplicate_intermediate_records
requirement
REQ-1245
expected/error.yaml
phase: verification
condition: duplicate_intermediate_records
spec_paths:
  - intermediates[0].verifications[0].unique
requirement: REQ-1245
context:
  intermediate: DS_EOS
  dataset: DS
  columns: [STUDYID, USUBJID]
  duplicate_count: 1

Inputs

Under review
2 source files

input/dm.csv

Edit
3 rows
input/dm.csv
STUDYIDUSUBJID
YAMAA-01
YAMAA-01
YAMAA-01

input/ds.csv

Edit
5 rows
input/ds.csv
STUDYIDUSUBJIDDSCATDSDECODDSSTDTC
YAMAA-01DISPOSITION EVENTSCREEN FAILURE2024-01-05
YAMAA-01DISPOSITION EVENTCOMPLETED2024-01-10
YAMAA-01DISPOSITION EVENTWITHDRAWAL BY SUBJECT2024-01-15
YAMAA-01DISPOSITION EVENTCOMPLETED2024-02-11
YAMAA-01DISPOSITION EVENTSCREEN FAILURE2024-03-02

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLEOSDTEnd of Study DatecharacterTake DSSTDTC from the DS record matching on the shared output keys, where DS.DSCAT = 'DISPOSITION EVENT' AND DS.DSDECOD <> 'SCREEN FAILURE', and a row with no match is an error.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml