Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attach the epoch (EPOCH) containing each collected vital-sign date.

Input: vital-sign records carrying a collected calendar date (VSDTC), plus an epoch table carrying a period name (EPOCH) with integer day bounds (DYLO, DYHI).

Variables:

  • EPOCH would be the period name from the epoch-table row whose day range contains the visit, and blank when no range does. A calendar date cannot be ordered directly against integer day bounds, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Prefer comparing the collected date with date bounds directly: match VSDTC between the subject's own element start and end dates (SESTDTC, SEENDTC from the subject-elements data), which is how SDTM assigns EPOCH:

between: {value: VSDTC, lower: SESTDTC, upper: SEENDTC}

Only when the epoch table must stay study-day based, derive the integer study day from the date and the subject's reference start date (RFSTDTC, read from demographics into a date column), then compare that value with the integer bounds:

- name: VSDY
  type: int
  derivation:
    study_day:
      date: VSDTC
      reference: RFSTDTC
between: {value: VSDY, lower: DYLO, upper: DYHI}

The study-day route needs demographics as an extra input, and it gives every subject the same epoch boundaries.

sdtm-vs-study-day attaches the epoch this way.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incomparable_range_types
requirement
REQ-0121
expected/error.yaml
phase: validation
condition: incomparable_range_types
spec_paths:
  - intermediates[0].between
requirement: REQ-0121
context:
  intermediate: EPOCHDEF
  value_type: date
  lower_type: int
  upper_type: int

Inputs

Under review
2 source files

input/epoch.csv

Edit
1 row
input/epoch.csv
STUDYIDEPOCHDYLODYHI
CATHTREATMENT156

input/vs.csv

Edit
1 row
input/vs.csv
STUDYIDUSUBJIDVSSEQVSDTC
CATH12025-01-08

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Variable NameVariable LabelTypeLengthControlled Terms or FormatOriginCoreConversion DefinitionVariable TypeVariable OrderComments for Define
STUDYIDStudy IdentifierCharCollectedCopy value from VS_RAW.STUDYID.SDTM1
USUBJIDUnique Subject IdentifierCharCollectedCopy value from VS_RAW.USUBJID.SDTM2
VSSEQSequence NumberNumCollectedCopy value from VS_RAW.VSSEQ.SDTM3
VSDTCDate/Time of MeasurementsCharISO 8601CollectedCopy value from VS_RAW.VSDTC.SDTM4
EPOCHEpochCharDerivedTake EPOCH from the EPOCHS record matching on STUDYID, where VSDTC falls within DYLO to DYHI, and a row with no match is an error.SDTM5
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml