Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry the investigator (INVID) responsible for each subject's site.

Input: collected demographics carrying the study site (SITEID) and its investigator (INVID).

Variables:

  • INVID would be the investigator of the subject's site, read from INVID.

Note: the record identity includes the site (SITEID), but the result does not carry it, so a reader of the result could not check which site a row answers for. The run is rejected before any data is read and no artifact is accepted.

How to fix

Every column that forms the record identity must appear in the output. If the site is part of the identity, carry it:

output:
  columns: [STUDYID, USUBJID, SITEID, INVID]

If study and subject already form the intended identity, drop the site from the identity instead:

keys: [STUDYID, USUBJID]

Choose the option that matches the output's actual row identity.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
internal_column_in_keys
requirement
REQ-0220
expected/error.yaml
phase: validation
condition: internal_column_in_keys
spec_paths:
  - keys[2]
requirement: REQ-0220
context:
  column: SITEID

Inputs

Under review
1 source file

input/dm.csv

Edit
2 rows
input/dm.csv
STUDYIDUSUBJIDSITEIDINVID
YAMAA-01701INV-701
YAMAA-01702INV-702

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADSLSTUDYIDStudy IdentifiercharacterCopy value from DM.STUDYID.Predecessor
ADSLUSUBJIDUnique Subject IdentifiercharacterCopy value from DM.USUBJID.Predecessor
ADSLINVIDInvestigator IdentifiercharacterCopy value from DM.INVID.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml