Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: draftEditUnder review
What this benchmark means
README.md

Goal: complete the analysis start date (ASTDT) of each adverse event (AE) from the collected start (AESTDTC), supplying a day only where the collected text already carries a month.

Input: collected event records carrying the reported term (AETERM) and the collected start (AESTDTC).

Variables:

  • ASTDT would be the analysis start date completed from AESTDTC: the 15th of the collected month for a year-and-month start, the collected date unchanged when it is already complete, and missing for a year-only start, because a start must carry at least a month. No collected start can therefore ever take a supplied month, so the written month 6 is unreachable and the run is rejected before any data is read. No artifact is accepted.

How to fix

Drop the month: nothing the policy accepts can use it.

date_impute:
  source: AE.AESTDTC
  day: 15
  minimum_source_precision: month

A year-and-month value such as 2023-06 then becomes 2023-06-15. A year-only value such as 2023 is still left missing, because the declared minimum forbids supplying both a month and a day.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
month_not_permitted
requirement
REQ-0592
expected/error.yaml
phase: validation
condition: month_not_permitted
spec_paths:
  - columns.ASTDT.derivation.date_impute.month
requirement: REQ-0592
context:
  month: 6

Inputs

Under review
1 source file

input/ae.csv

Edit
3 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAETERMAESTDTC
YAMAA-011Nausea2023
YAMAA-012Headache2023-06
YAMAA-013Fatigue2023-06-14

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEAETERMReported Term for the Adverse EventcharacterCopy value from AE.AETERM.Predecessor
ADAEAESTDTCStart Date/Time of Adverse EventcharacterCopy value from AE.AESTDTC.Predecessor
ADAEASTDTAnalysis Start DatenumericISO 8601Impute incomplete date from AE.AESTDTC, defaulting month=6, day=15; missing or invalid input yields null.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml