Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: build the analysis start date (ASTDT) for each collected adverse event (AE), completing a start recorded without a day.

Input: collected adverse events carrying the reported start (AESTDTC), which is sometimes a year and month with no day and sometimes a year with no month.

Variables:

  • ASTDT would contain the collected start, kept as collected when it is a complete date and otherwise completed with day mid (and month 6 for a year alone).

The day value mid is neither a day number nor one of the two positions every month has, first and last, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Decide where in the month the analysis date should fall, then name a position a calendar fixes or name the day itself. To place a start recorded as a year and month on the first of that month:

date_impute:
  source: AE.AESTDTC
  month: 6
  day: first

A value such as 2023-06 then becomes 2023-06-01. Writing day: last instead gives 2023-06-30, and writing day: 15 names the fifteenth of the collected month directly.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
value_not_permitted
requirement
REQ-0609
expected/error.yaml
phase: validation
condition: value_not_permitted
spec_paths:
  - columns.ASTDT.derivation.date_impute.day
requirement: REQ-0609
context:
  value: mid
  permitted: [first, last]

Inputs

Under review
1 source file

input/ae.csv

Edit
3 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAETERMAESTDTC
YAMAA-011Headache2023-06
YAMAA-012Pyrexia2023-06-14
YAMAA-011Nausea2023

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEASTDTAnalysis Start DatenumericISO 8601Impute incomplete date from AE.AESTDTC, defaulting month=6, day=mid; missing or invalid input yields null.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml