Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: complete the analysis end date (AENDT) for each adverse event (AE), rejecting any completion that lands on a day the month never has.

Input: adverse event records carrying collected end text (AEENDTC) and reported term (AETERM).

Variables:

  • AENDT would be the analysis end date completed from AEENDTC: a year alone becomes 31 December, a year and month becomes the 31st of that month, and a complete date is kept as collected. A year and month whose month has fewer than 31 days would complete to a day that month never has, which is not a calendar date, so the run fails and no artifact is accepted.

How to fix

Decide which day an end date collected without one should take. To keep the latest date the collected text allows, name the last day of the month rather than a number:

date_impute:
  source: AE.AEENDTC
  month: 12
  day: last

A year and month such as 2023-04 then completes to 2023-04-30 instead of the impossible 2023-04-31, 2023-07 still completes to 2023-07-31, and a February takes the 28th or 29th according to the year. A fixed day from 1 through 28 is valid in every month too, but it is a different imputation policy, not a repair of this one.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
impute
condition
invalid_calendar_date
requirement
REQ-0608
expected/error.yaml
phase: impute
condition: invalid_calendar_date
spec_paths:
  - columns.AENDT.derivation.date_impute
requirement: REQ-0608
context:
  value: "2023-04"
  completed: "2023-04-31"
  keys:
    - STUDYID: YAMAA-01
      USUBJID: YAMAA-01-101
      AESEQ: 2

Inputs

Under review
1 source file

input/ae.csv

Edit
2 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAETERMAEENDTC
YAMAA-011Nausea2023-07
YAMAA-012Fatigue2023-04

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEAENDTAnalysis End DatenumericISO 8601Impute incomplete date from AE.AEENDTC, defaulting month=12, day=31; missing or invalid input yields null.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml