Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive AVAL, ANRHI, and HIFL for each subject and parameter, flagging collected laboratory results that lie above their reference range.

Input: collected laboratory records carrying the study and subject identifiers with LBTESTCD, the test code; LBSTRESN, the numeric result; and LBSTNRHI, the upper limit of its reference range.

Variables:

  • AVAL would be the collected result, taken from LBSTRESN.
  • ANRHI would be the upper limit of the reference range, taken from LBSTNRHI.
  • HIFL would be 1 for a result above that limit and 0 otherwise.

Note: the flag is written as the comparison AVAL > ANRHI inside a formula. A formula produces a number, while a comparison answers yes or no; turning that answer into 1 or 0, or into text, would each be a different result from the same comparison, so the run is rejected before any data is read and no artifact is accepted. HIFL is this benchmark's own invention, documented here; AVAL and ANRHI follow ADaMIG-1.3.

How to fix

Ask the comparison where the flag is decided, so the conversion from a yes-or-no answer to 1 or 0 is explicit:

- name: HIFL
  type: int
  derivation:
    case:
      - when: "AVAL > ANRHI"
        then: {literal: 1}
      - otherwise: {literal: 0}

A missing result or limit answers neither yes nor no, so it falls to otherwise and gets 0; to leave such a flag empty instead, replace the otherwise with when: "AVAL <= ANRHI" returning 0.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
prohibited_construct
requirement
REQ-0441
expected/error.yaml
phase: validation
condition: prohibited_construct
spec_paths:
  - columns.HIFL.derivation.compute.expr
requirement: REQ-0441
context:
  expr: "AVAL > ANRHI"
  construct: comparison

Inputs

Under review
1 source file

input/lb.csv

Edit
2 rows
input/lb.csv
STUDYIDUSUBJIDLBTESTCDLBSTRESNLBSTNRHI
YAMAA-01ALT4235
YAMAA-01ALT2035

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBPARAMCDParameter CodecharacterCopy value from LB.LBTESTCD.Predecessor
ADLBAVALAnalysis ValuenumericCopy value from LB.LBSTRESN.Predecessor
ADLBANRHIAnalysis Normal Range Upper LimitnumericCopy value from LB.LBSTNRHI.Predecessor
ADLBHIFLHigh Result FlagnumericCompute AVAL > ANRHI.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml