Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: count the exposure start (EXSTDY) in days since 1970-01-01, for exposure records with sequence number 1.

Input: exposure records, each identified by study, subject, and sequence, carrying the start date as collected text (EXSTDT).

Variables:

  • EXSTDY would hold the number of days from 1970-01-01 to the exposure start, negative for an earlier date. Only a date can be counted, and the start is still text that nothing has read as a date, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Read the collected start as a date before counting days. The simplest correction declares the field's type on the input, so the text becomes a date as it is read and a start that is not a complete date is rejected there:

input:
  EX: {path: input/ex.csv, types: {EXSEQ: int, EXSTDT: date}}

If a start that is not a complete date should leave the day count empty instead, bind the text to an internal date column that answers the failed conversion, and count from that column:

- name: ASTDT
  type: date
  derivation:
    value:
      source: EX.EXSTDT
    unconvertible: null

- name: EXSTDY
  type: int
  derivation:
    to_epoch_day:
      source: ASTDT

to_epoch_day takes a variable as its source, so a to_date nested inside it is itself rejected.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
incompatible_input_type
requirement
REQ-0606
expected/error.yaml
phase: validation
condition: incompatible_input_type
spec_paths:
  - columns.EXSTDY.derivation.to_epoch_day.source
requirement: REQ-0606
context:
  source: EX.EXSTDT
  expected: date
  actual: str

Inputs

Under review
1 source file

input/ex.csv

Edit
1 row
input/ex.csv
STUDYIDUSUBJIDEXSEQEXSTDT
YAMAA-0112024-01-15

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADEXSTUDYIDStudy IdentifiercharacterCopy value from EX.STUDYID.Predecessor
ADEXUSUBJIDUnique Subject IdentifiercharacterCopy value from EX.USUBJID.Predecessor
ADEXEXSEQSequence NumbernumericCopy value from EX.EXSEQ.Predecessor
ADEXEXSTDYEpoch Day of Exposure StartnumericDays since 1970-01-01 for EX.EXSTDT.Derived
TemplateInclude when
exposureEX.EXSEQ = 1
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml