Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: double the administered exposure dose in DOSEDBL for each subject.

Input: a subject-treatment inventory carrying EXTRT with matching exposure records carrying the exposure sequence number and EXDOSE.

Variables:

  • DOSEDBL would contain twice the exposure dose (EXDOSE * 2) for the subject. A subject can have several exposure records, so a formula naming EX.EXDOSE does not say which record it means, and choosing one without a stated rule, or totalling them, would each give a different result. A formula computes only from values the output row already carries, and a value taken from another source is bound to one of those first, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Choose the exposure record explicitly, bind its dose to an output column, and then compute from the unqualified column. For example, to use the earliest administration:

- name: DOSE
  type: float
  derivation:
    source:
      variable: EX.EXDOSE
      order_by: [EX.EXSEQ]
      keep: first

- name: DOSEDBL
  type: float
  derivation:
    compute:
      expr: "DOSE * 2"

Keep DOSE internal by omitting it from output.columns.

If the intended value is cumulative dose instead, use a qualified aggregate rather than selecting one record.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
qualified_identifier
requirement
REQ-0442
expected/error.yaml
phase: validation
condition: qualified_identifier
spec_paths:
  - columns.DOSEDBL.derivation.compute.expr
requirement: REQ-0442
context:
  expr: "EX.EXDOSE * 2"
  identifier: EX.EXDOSE

Inputs

Under review
2 source files

input/ex.csv

Edit
2 rows
input/ex.csv
STUDYIDUSUBJIDEXSEQEXDOSE
YAMAA-011200
YAMAA-012200

input/subject_treatment.csv

Edit
1 row
input/subject_treatment.csv
STUDYIDUSUBJIDEXTRT
YAMAA-01Pembrolizumab

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADEXSTUDYIDStudy IdentifiercharacterCopy value from TRT.STUDYID.Predecessor
ADEXUSUBJIDUnique Subject IdentifiercharacterCopy value from TRT.USUBJID.Predecessor
ADEXDOSEDBLDoubled DosenumericCompute EX.EXDOSE * 2.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml