Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: carry each adverse event (AE) term into AETERM and its start moment into ASTDTM.

Input: collected adverse event records carrying term (AETERM) and start text (AESTDTC).

Variables:

  • ASTDTM would contain the start moment copied from AESTDTC, a site-clock reading with no clock offset. A start that carries an offset, such as +02:00, is not the same kind of value, so the run stops while converting values and no artifact is accepted.

How to fix

Decide whether the study collects an offset at all. If the site clock is what was recorded, correct the collected value so every start reads the same way:

YAMAA-01,YAMAA-01-101,2,HEADACHE,2025-03-04T09:00:00

If the offset is real data, collect it as a field of its own and keep AESTDTC to the site clock. ASTDTM then holds the moment and a second text column holds the offset, where a later analysis can read it.

To inspect the collected characters without failing, carry them in an intermediate text column that is not ASTDTM:

- name: AESTDTC_RAW
  type: str
  label: Collected Start Text
  derivation: AE.AESTDTC

The text keeps the collected characters but does not order chronologically across offsets, and it is not an analysis variable: ASTDTM stays a moment.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
convert
condition
conversion_failed
requirement
REQ-0601
expected/error.yaml
phase: convert
condition: conversion_failed
spec_paths:
  - columns.ASTDTM
requirement: REQ-0601
context:
  from: str
  to: datetime
  value: "2025-03-04T09:00:00+02:00"
  keys:
    - STUDYID: YAMAA-01
      USUBJID: YAMAA-01-101
      AESEQ: 2

Inputs

Under review
1 source file

input/ae.csv

Edit
2 rows
input/ae.csv
STUDYIDUSUBJIDAESEQAETERMAESTDTC
YAMAA-011NAUSEA2025-03-04T09:00:00
YAMAA-012HEADACHE2025-03-04T09:00:00+02:00

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADAESTUDYIDStudy IdentifiercharacterCopy value from AE.STUDYID.Predecessor
ADAEUSUBJIDUnique Subject IdentifiercharacterCopy value from AE.USUBJID.Predecessor
ADAEAESEQSequence NumbernumericCopy value from AE.AESEQ.Predecessor
ADAEAETERMReported Term for the Adverse EventcharacterCopy value from AE.AETERM.Predecessor
ADAEASTDTMAnalysis Start Date/TimenumericISO 8601Copy value from AE.AESTDTC.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml