Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: derive AVAL from the collected pulse rate.

Input: collected vital signs (VS) records carrying VSTESTCD and VSSTRESN; one record carries a fractional pulse rate.

Variables:

  • AVAL would be the collected result from VSSTRESN, held as a whole number. A fractional result has no whole-number form unless a rounding rule is stated, so the run fails and no artifact is accepted.

How to fix

If fractional pulse rates are valid for the analysis, preserve the collected precision by declaring the result as float:

- name: AVAL
  type: float
  derivation:
    source: VS.VSSTRESN

If the result must be an integer, the specification must choose an explicit rule, such as round_half_away_from_zero with digits: 0, or FLOOR, CEIL, or TRUNC in a compute expression; conversion will not choose a rounding rule implicitly.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
convert
condition
conversion_failed
requirement
REQ-0021
expected/error.yaml
phase: convert
condition: conversion_failed
spec_paths:
  - columns.AVAL
requirement: REQ-0021
context:
  from: float
  to: int
  value: 72.5
  keys:
    - STUDYID: YAMAA-01
      USUBJID: YAMAA-01-101
      VSSEQ: 2

Inputs

Under review
1 source file

input/vs.csv

Edit
2 rows
input/vs.csv
STUDYIDUSUBJIDVSSEQVSTESTCDVSSTRESN
YAMAA-011PULSE68
YAMAA-012PULSE72.5

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADVSSTUDYIDStudy IdentifiercharacterCopy value from VS.STUDYID.Predecessor
ADVSUSUBJIDUnique Subject IdentifiercharacterCopy value from VS.USUBJID.Predecessor
ADVSVSSEQSequence NumbernumericCopy value from VS.VSSEQ.Predecessor
ADVSAVALAnalysis ValuenumericCopy value from VS.VSSTRESN.Derived
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml