Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: attempt one laboratory analysis record per collected laboratory result, carrying AVAL for the numeric analysis value.

Input: collected laboratory results with the result in standard units (LBSTRESN).

Variables:

  • AVAL would be the numeric analysis value, copying LBSTRESN. Whole and fractional numbers are stored as different kinds of value, but the declared kind says only number. Choosing either representation would invent a precision decision the declaration did not make, so the run is rejected before any data is read and no artifact is accepted.

How to fix

Choose the type from the measurement contract. Use int only when fractions are impossible; otherwise use float:

- name: AVAL
  type: float
  label: Analysis Value
  derivation: LB.LBSTRESN

The allowed column types are str, int, float, date, and datetime.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
validation
condition
value_not_permitted
requirement
REQ-0012
expected/error.yaml
phase: validation
condition: value_not_permitted
spec_paths:
  - columns.AVAL.type
requirement: REQ-0012
context:
  value: number
  permitted: [str, int, float, date, datetime]

Inputs

Under review
1 source file

input/lb.csv

Edit
1 row
input/lb.csv
STUDYIDUSUBJIDLBSEQLBSTRESN
PILOT7112.5

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from LB.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from LB.USUBJID.Predecessor
ADLBLBSEQSequence NumbernumericCopy value from LB.LBSEQ.Predecessor
ADLBAVALAnalysis ValuenumberCopy value from LB.LBSTRESN.Predecessor
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml