Review ask

As a clinical trial statistician or programmer, challenge anything in this benchmark: describe a problem in Comments, or propose a fix with the Edit button on any source file.

  1. Task: Is this a specification error a study team could realistically make, and should the build stop on it rather than continue?
  2. Inputs: Do they trigger the failure for the reason the summary gives?
  3. Expected failure: Is this the right error, raised at the right point, and would it tell the programmer what to fix?

The other tabs beside Comments are background for assessment, not under review.

Summary

Lifecycle: reviewedEditUnder review
What this benchmark means
README.md

Goal: add an absolute lymphocyte (LYMPH) record carrying AVAL and DTYPE.

Input: collected laboratory records carrying the collected result in AVAL, identified by subject, visit, and parameter code, including white blood cell (WBC) counts and lymphocyte fractions (LYMLE).

Variables:

  • AVAL: the collected result on collected records. On the new LYMPH record it is the WBC count multiplied by the LYMLE fraction from the same subject and visit; that record is added only when both values are present and no LYMPH result was collected at the visit.
  • DTYPE: CALCULATION on the new LYMPH record, empty on collected records.

Note: each contributing parameter may occur at most once within a subject and visit. A repeated WBC or LYMLE result leaves no single value to multiply, so the run stops with no artifact rather than choosing one record by amount or position or adding both values.

How to fix

Resolve the duplicate WBC records according to the study's data conventions before calculating the absolute differential. The run then sees one WBC record per subject and visit, for example:

STUDYID,USUBJID,PARAMCD,AVAL,PARAM,VISIT
YAMAA-01,YAMAA-01-101,WBC,34,Leukocyte Count (10^9/L),CYCLE 1 DAY 1
YAMAA-01,YAMAA-01-101,LYMLE,0.90,Lymphocytes (fraction of 1),CYCLE 1 DAY 1

Do not replace ONLY with MIN, MAX, or file-order selection unless that choice is a documented clinical rule; those alternatives answer a different question.

Expected failure

Edit
the run is rejected; no artifact is accepted
expected/error.yaml
phase
row_construction
condition
aggregate_multiple_records
requirement
REQ-0501
expected/error.yaml
phase: row_construction
condition: aggregate_multiple_records
spec_paths:
  - rows[1].derivations.WBCVAL.aggregate
requirement: REQ-0501
context:
  expr: ONLY(ADLB_RAW.AVAL)
  reducer: ONLY
  row: derived_lymph
  group:
    STUDYID: YAMAA-01
    USUBJID: YAMAA-01-101
    VISIT: CYCLE 1 DAY 1
  record_count: 2

Inputs

Under review
1 source file

input/adlb.csv

Edit
3 rows
input/adlb.csv
STUDYIDUSUBJIDPARAMCDAVALPARAMVISIT
YAMAA-01WBC33Leukocyte Count (10^9/L)CYCLE 1 DAY 1
YAMAA-01WBC34Leukocyte Count (10^9/L)CYCLE 1 DAY 1
YAMAA-01LYMLE0.90Lymphocytes (fraction of 1)CYCLE 1 DAY 1

Unexpected Output

Under review
No artifact is produced

No fixture files in this directory.

Shaded columns are derived— = missing value

Comments and assessment materials

Comments

Signed in with GitHub; saved in repository Discussions

Mapping spec

Generated from the benchmark YAML; do not edit by hand

Dataset NameVariable NameVariable LabelTypeCodelist/Controlled TermsCoreComputational MethodOrigin
ADLBSTUDYIDStudy IdentifiercharacterCopy value from ADLB_RAW.STUDYID.Predecessor
ADLBUSUBJIDUnique Subject IdentifiercharacterCopy value from ADLB_RAW.USUBJID.Predecessor
ADLBVISITVisit NamecharacterCopy value from ADLB_RAW.VISIT.Predecessor
ADLBPARAMCDParameter CodecharacterSet per constructed row; see the Row construction sheet.Derived
ADLBPARAMParametercharacterSet per constructed row; see the Row construction sheet.Derived
ADLBAVALAnalysis ValuenumericSet per constructed row; see the Row construction sheet.Derived
ADLBDTYPEDerivation TypecharacterSet per constructed row; see the Row construction sheet.Derived
TemplateInclude whenPARAMCDPARAMWBCVALLYMLEVALEXISTING_ABS_COUNTAVALDTYPE
collectedCopy ADLB_RAW.PARAMCDCopy ADLB_RAW.PARAMConstant "None"Constant "None"Constant "None"Copy ADLB_RAW.AVALConstant "None"
derived_lymphWBCVAL IS NOT NULL AND LYMLEVAL IS NOT NULL AND EXISTING_ABS_COUNT IS NULLConstant "LYMPH"Constant "Lymphocytes Abs (10^9/L)"Aggregate ONLY(ADLB_RAW.AVAL) over records matching on the shared output keys, where ADLB_RAW.PARAMCD = 'WBC'Aggregate ONLY(ADLB_RAW.AVAL) over records matching on the shared output keys, where ADLB_RAW.PARAMCD = 'LYMLE'Aggregate COUNT(ADLB_RAW.*) over records matching on the shared output keys, where ADLB_RAW.PARAMCD = 'LYMPH'Compute WBCVAL * LYMLEVALConstant "CALCULATION"
VersionDateAuthorDescriptionReviewerSign-off
1.32026-09-29yamaa docs buildShow study codelist names, external dictionaries, and ISO 8601 formats in variable rows; list the document's codelist values and metadata
1.22026-09-29yamaa docs buildClassify ADaM copies from a declared input as Predecessor and recodes as Derived, and SDTM recodes of locally derived columns as Derived
1.12026-09-29yamaa docs buildResolve lookups into the donor record they select, and give every derivation shape a plain-language rule instead of its raw YAML
1.0yamaa docs buildInitial generation from spec.yaml